Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include a menu to filter and sort the wallets of the sidebar #1068

Merged
merged 15 commits into from Feb 18, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 10, 2019

Proposed changes

This PR:

  • Refactors several theme styles
  • Refactors the sidebar to use reactiveness
  • Implements the filters and sorting feature on the wallet sidebar

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@codecov-io

This comment has been minimized.

Copy link

commented Feb 12, 2019

Codecov Report

Merging #1068 into develop will increase coverage by 0.57%.
The diff coverage is 43.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1068      +/-   ##
===========================================
+ Coverage    39.62%   40.19%   +0.57%     
===========================================
  Files          205      207       +2     
  Lines         5164     5210      +46     
  Branches      1013     1028      +15     
===========================================
+ Hits          2046     2094      +48     
- Misses        2998     2999       +1     
+ Partials       120      117       -3
Impacted Files Coverage Δ
...er/components/Menu/MenuOptions/MenuOptionsItem.vue 50% <ø> (+50%) ⬆️
src/renderer/store/modules/wallet.js 52.05% <ø> (+0.7%) ⬆️
...nents/App/AppSidemenu/AppSidemenuNetworkStatus.vue 0% <0%> (ø) ⬆️
...components/App/AppSidemenu/AppSidemenuSettings.vue 0% <0%> (ø) ⬆️
.../WalletSidebar/WalletSidebarFiltersSearchInput.vue 14.28% <14.28%> (ø)
...ents/Wallet/WalletSidebar/WalletSidebarFilters.vue 15% <15%> (ø)
src/renderer/directives/click-outside.js 50% <50%> (ø) ⬆️
.../components/Wallet/WalletSidebar/WalletSidebar.vue 59.7% <76.92%> (+49.28%) ⬆️
src/renderer/store/modules/peer.js 68.69% <0%> (-3.74%) ⬇️
src/renderer/services/client.js 66.22% <0%> (-1.01%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7fddee...7eb0a6a. Read the comment docs.

@j-a-m-l j-a-m-l changed the title [WIP] feat: include a menu to filter and sort the wallets of the sidebar feat: include a menu to filter and sort the wallets of the sidebar Feb 12, 2019

@luciorubeens
Copy link
Member

left a comment

Very good! Worked flawlessly and I did not identify problems in the code :magic:

@luciorubeens luciorubeens merged commit e9f172e into develop Feb 18, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the sidebar-filters branch Feb 18, 2019

@dated dated referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.