Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow navigating to delegate addresses on the vote delegate modal #1072

Merged
merged 1 commit into from Feb 13, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 12, 2019

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 12, 2019

Codecov Report

Merging #1072 into develop will decrease coverage by 0.15%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1072      +/-   ##
===========================================
- Coverage    39.62%   39.46%   -0.16%     
===========================================
  Files          205      205              
  Lines         5164     5169       +5     
  Branches      1013     1018       +5     
===========================================
- Hits          2046     2040       -6     
- Misses        2998     3007       +9     
- Partials       120      122       +2
Impacted Files Coverage Δ
...nderer/components/Transaction/TransactionModal.vue 32.94% <ø> (ø) ⬆️
src/renderer/components/Wallet/WalletAddress.vue 50% <ø> (-3.85%) ⬇️
...ponents/Wallet/WalletDelegates/WalletDelegates.vue 48.93% <0%> (ø) ⬆️
...ts/Transaction/TransactionForm/TransactionForm.vue 41.66% <100%> (-3.79%) ⬇️
...ransaction/TransactionForm/TransactionFormVote.vue 8.57% <66.66%> (+0.8%) ⬆️
src/renderer/store/modules/peer.js 70.56% <0%> (-1.87%) ⬇️
src/renderer/services/client.js 66.22% <0%> (-1.01%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7fddee...e9d32ca. Read the comment docs.

@luciorubeens
Copy link
Member

left a comment

It's ok! 👍

@luciorubeens luciorubeens merged commit 6a7f042 into develop Feb 13, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the allow-navigating-to-delegates branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.