Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: infer the market ticker of custom networks by checking CryptoCompare #1073

Merged
merged 4 commits into from Feb 21, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 12, 2019

Proposed changes

Resolves #1046

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@luciorubeens
Copy link
Member

left a comment

Sounds good to me, I just found a bug related in the vuex module. We are using the network token and not the market ticker:

https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/renderer/store/modules/market.js#L25

Can you change it to network.market.ticker?

@j-a-m-l j-a-m-l requested a review from faustbrian as a code owner Feb 21, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 21, 2019

Codecov Report

Merging #1073 into develop will decrease coverage by 0.26%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1073      +/-   ##
===========================================
- Coverage    39.62%   39.35%   -0.27%     
===========================================
  Files          205      205              
  Lines         5164     5173       +9     
  Branches      1013     1014       +1     
===========================================
- Hits          2046     2036      -10     
- Misses        2998     3014      +16     
- Partials       120      123       +3
Impacted Files Coverage Δ
src/renderer/store/modules/market.js 4.54% <0%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (+0.62%) ⬆️
src/renderer/services/crypto-compare.js 66.66% <0%> (-13.34%) ⬇️
src/renderer/store/modules/peer.js 68.69% <0%> (-3.74%) ⬇️
src/renderer/services/client.js 66.22% <0%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7fddee...1bb22f3. Read the comment docs.

@luciorubeens luciorubeens merged commit b7a0d7c into develop Feb 21, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the infer-custom-network-ticker branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.