feat: revamp the introductory screens and allow choosing language #1074
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1074 +/- ##
===========================================
- Coverage 39.62% 39.48% -0.14%
===========================================
Files 205 204 -1
Lines 5164 5164
Branches 1013 1014 +1
===========================================
- Hits 2046 2039 -7
- Misses 2998 3003 +5
- Partials 120 122 +2
Continue to review full report at Codecov.
|
@@ -0,0 +1,142 @@ | |||
<template> | |||
<div class="flex flex-row w-full h-full"> | |||
<div class="AppIntroScreen__container__left flex-1 animated fadeIn rounded-lg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should follow the same responsiveness as the other screens:
<div class="AppIntroScreen__container__left flex-1 animated fadeIn rounded-lg"> | |
<div class="AppIntroScreen__container__left flex-1 animated fadeIn rounded-lg hidden lg:block"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, removing the left part makes it better for smaller screens
v-if="showFooter" | ||
name="buttons" | ||
> | ||
<div class="flex flex-row w-full justify-between px-16 pb-16 sm:px-10 sm:pb-10"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial style should be switched, and replicated to the parent elements.
<div class="flex flex-row w-full justify-between px-16 pb-16 sm:px-10 sm:pb-10"> | |
<div class="flex flex-row w-full justify-between px-10 pb-10 md:px-16 md:pb-16"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this; since now the left part (the image) is removed, this trick isn't necessary
<MenuDropdown | ||
:items="languages" | ||
:value="language" | ||
:position="['-50%', '0%']" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This positioning is awkward because it is misaligned to the input. I think you making the same adjustments made to the ProfileEdition will look better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I didn't realize how awkward was. I've also improved the style of the items.
@j-a-m-l Your pull request needs some changes. Please wait for a comment from one of our developers for more information. |
@luciorubeens I've followed your suggestions and included some additional changes |
Proposed changes
This PR revamps the introductory screens and add the possibility to choose language at the beginning.
Types of changes
Checklist