Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ask users, when leaving the profile edition without having saved it, if they want to do it #1077

Merged
merged 7 commits into from Feb 15, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 14, 2019

Proposed changes

Resolves #1018.

Users could:
a) Close the modal and continue on the profile edition
b) Ignore the modified settings and navigate to the expected route
c) Save the modified settings and navigate to the expected route

Apart from that, it fixes that, the order on the profiles page is altered after updating a profile.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l j-a-m-l changed the base branch from master to develop Feb 14, 2019

@j-a-m-l j-a-m-l changed the title feat: feat: ask users, when leaving the profile edition without having saved it, if they want to do it Feb 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 14, 2019

Codecov Report

Merging #1077 into develop will decrease coverage by 0.13%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1077      +/-   ##
===========================================
- Coverage    39.46%   39.32%   -0.14%     
===========================================
  Files          205      206       +1     
  Lines         5169     5187      +18     
  Branches      1013     1020       +7     
===========================================
  Hits          2040     2040              
- Misses        3007     3024      +17     
- Partials       122      123       +1
Impacted Files Coverage Δ
...er/components/Wallet/WalletRemovalConfirmation.vue 33.33% <ø> (ø) ⬆️
.../components/Contact/ContactRemovalConfirmation.vue 33.33% <ø> (ø) ⬆️
.../components/Profile/ProfileRemovalConfirmation.vue 93.33% <ø> (ø) ⬆️
...components/App/AppSidemenu/AppSidemenuSettings.vue 0% <ø> (ø) ⬆️
...action/TransactionForm/TransactionFormTransfer.vue 5.42% <ø> (ø) ⬆️
...rc/renderer/components/Modal/ModalConfirmation.vue 57.14% <ø> (-9.53%) ⬇️
src/renderer/pages/Profile/ProfileEdition.vue 8.82% <0%> (+0.03%) ⬆️
src/renderer/pages/Profile/ProfileAll.vue 75.75% <100%> (+0.75%) ⬆️
.../components/Profile/ProfileLeavingConfirmation.vue 40% <40%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7f042...c7b4db6. Read the comment docs.

@j-a-m-l j-a-m-l merged commit b553ad8 into develop Feb 15, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the ask-when-profile-was-changed branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.