Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the time format setting to the profile creation #1079

Merged
merged 3 commits into from Feb 18, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 15, 2019

Proposed changes

That setting was on the profile edition, but not on the profile creation

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Feb 15, 2019

Codecov Report

Merging #1079 into develop will increase coverage by 0.21%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1079      +/-   ##
===========================================
+ Coverage    39.32%   39.54%   +0.21%     
===========================================
  Files          205      205              
  Lines         5187     5177      -10     
  Branches      1016     1014       -2     
===========================================
+ Hits          2040     2047       +7     
+ Misses        3024     3010      -14     
+ Partials       123      120       -3
Impacted Files Coverage Δ
src/renderer/pages/Profile/ProfileEdition.vue 8.79% <ø> (-0.04%) ⬇️
src/renderer/pages/Profile/ProfileNew.vue 7.04% <0%> (-0.9%) ⬇️
src/renderer/mixins/formatter.js 76.92% <100%> (ø) ⬆️
src/renderer/pages/Profile/ProfileAll.vue 75% <0%> (-0.76%) ⬇️
src/renderer/components/App/index.js 0% <0%> (ø) ⬆️
src/renderer/components/App/AppIntro/index.js
.../components/Profile/ProfileLeavingConfirmation.vue
src/renderer/components/App/AppIntro/AppIntro.vue
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f7277...4651c5e. Read the comment docs.

@j-a-m-l j-a-m-l changed the title [WIP] feat: add the time format setting to the profile creation feat: add the time format setting to the profile creation Feb 15, 2019

src/renderer/store/modules/session.js Outdated Show resolved Hide resolved
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@j-a-m-l Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

Update src/renderer/store/modules/session.js
Co-Authored-By: j-a-m-l <j-a-m-l@users.noreply.github.com>

@j-a-m-l j-a-m-l requested review from alexbarnsley and faustbrian as code owners Feb 18, 2019

@luciorubeens luciorubeens merged commit 13d1120 into develop Feb 18, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the add-time-format-to-profile-creation branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.