Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remote sorting to delegate table #1080

Merged
merged 3 commits into from Feb 16, 2019

Conversation

@dated
Copy link
Contributor

commented Feb 15, 2019

Proposed changes

Adds remote sorting to the delegate table. Replaces #763

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@alexbarnsley @j-a-m-l @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l
Copy link
Contributor

left a comment

Clicking on the names of the columns doesn't sort them (tested on mainnet and devnet): the request always uses rank:asc.

* @return {Object[]}
*/
async fetchDelegates ({ page, limit } = {}) {
async fetchDelegates (options = {}) {

This comment has been minimized.

Copy link
@j-a-m-l

j-a-m-l Feb 15, 2019

Contributor

@dated , I'm curious, why do you prefer using options instead of destructuring the object here?

This comment has been minimized.

Copy link
@dated

dated Feb 15, 2019

Author Contributor

Just for conformity in regards to the other methods, such as fetchWalletTransactions.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@dated Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

@dated A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit 6704056 into ArkEcosystem:develop Feb 16, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

@dated Your pull request has been merged and marked as tier 2. It will earn you $50 USD.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

Thanks, @dated

@dated dated deleted the dated:remote-delegates branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.