Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: configure the new Ark Shield address #1081

Merged
merged 1 commit into from Feb 18, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 16, 2019

Proposed changes

The address changed, so this PR, adds the new one, but it keeps the former too.

Types of changes

  • Other... Please describe: configuration

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 16, 2019

Codecov Report

Merging #1081 into develop will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1081      +/-   ##
===========================================
- Coverage    39.56%   39.35%   -0.22%     
===========================================
  Files          205      205              
  Lines         5189     5189              
  Branches      1016     1021       +5     
===========================================
- Hits          2053     2042      -11     
- Misses        3016     3024       +8     
- Partials       120      123       +3
Impacted Files Coverage Δ
src/renderer/store/modules/peer.js 68.69% <0%> (-3.74%) ⬇️
src/renderer/services/client.js 66.33% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6704056...935255c. Read the comment docs.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2019

@alexbarnsley @luciorubeens @boldninja, should we remove the old address? Should we rename it to "Ark Shield (old)" instead?

@luciorubeens
Copy link
Member

left a comment

SGTM this way 👍

@j-a-m-l j-a-m-l merged commit 9b599b3 into develop Feb 18, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the new-ark-shield branch Feb 18, 2019

@dated

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

the old address was completely removed on the explorer ArkEcosystem/explorer#561, which makes more sense imho as the old one won't be used again as it seems.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

Maybe, but some users might find it useful knowing the former address. @boldninja what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.