Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the configured time format on the market chart #1086

Merged
merged 3 commits into from Feb 27, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 19, 2019

Proposed changes

When adding the time format setting, the market chart was not adapted.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 19, 2019

Codecov Report

Merging #1086 into develop will increase coverage by 0.05%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1086      +/-   ##
==========================================
+ Coverage    40.14%   40.2%   +0.05%     
==========================================
  Files          207     207              
  Lines         5243    5253      +10     
  Branches      1032    1036       +4     
==========================================
+ Hits          2105    2112       +7     
- Misses        3022    3024       +2     
- Partials       116     117       +1
Impacted Files Coverage Δ
...rc/renderer/components/MarketChart/MarketChart.vue 31.46% <50%> (+9.66%) ⬆️
src/renderer/mixins/formatter.js 83.33% <75%> (+6.41%) ⬆️
src/renderer/store/modules/peer.js 68.69% <0%> (-1.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11c7b2...3b20cb0. Read the comment docs.

@luciorubeens luciorubeens merged commit 942385a into develop Feb 27, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the date-format-on-chart branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.