Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the cursor pointer on the pagination "rows per page" dropdown #1087

Merged
merged 1 commit into from Feb 25, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 19, 2019

Proposed changes

This PR was initially intended to fix a problem detected with the pagination on the transaction table.

Since the source of the bug is on core (ArkEcosystem/core#2118), the only thing that has been changed is a tiny UX fix.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l j-a-m-l changed the title fix: use the cursor pointer on the pagination rows per page fix: use the cursor pointer on the pagination "rows per page" dropdown Feb 19, 2019

@luciorubeens luciorubeens merged commit 0f0e460 into develop Feb 25, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-pagination-cursor branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.