Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: how cryptocurrencies are formatted when localized and displaying with symbols #1089

Merged
merged 4 commits into from Feb 27, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 20, 2019

Proposed changes

Related to #1075

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@dated

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

What's the general preference between Math.pow(), e notation and decimals? I can see all sorts of combinations in the tests

amount = Math.pow(10, 5) + Math.pow(10, -5)
amount = Math.pow(10, 4) + 1e-2
amount = Math.pow(10, 12) + 0.01
@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

There isn't any kind of preference

@j-a-m-l j-a-m-l merged commit 9f8d178 into develop Feb 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-localized-currency-format branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.