Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move "Chart on dashboard" setting to profile creation and edition #1091

Merged
merged 3 commits into from Feb 28, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 21, 2019

Proposed changes

This PR is part of the changes to revamp how we structure the settings.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@j-a-m-l j-a-m-l requested a review from alexbarnsley as a code owner Feb 21, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 21, 2019

Codecov Report

Merging #1091 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1091      +/-   ##
===========================================
- Coverage    40.34%   40.33%   -0.01%     
===========================================
  Files          207      207              
  Lines         5242     5248       +6     
  Branches      1033     1029       -4     
===========================================
+ Hits          2115     2117       +2     
- Misses        3013     3017       +4     
  Partials       114      114
Impacted Files Coverage Δ
...components/App/AppSidemenu/AppSidemenuSettings.vue 0% <ø> (ø) ⬆️
src/renderer/pages/Profile/ProfileNew.vue 7.79% <0%> (+0.74%) ⬆️
src/renderer/pages/Profile/ProfileEdition.vue 9.43% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495a1b2...866d3c2. Read the comment docs.

@alexbarnsley alexbarnsley changed the title feat: move the "Chart on dashboard" setting to the profile creation and edition feat: move "Chart on dashboard" setting to profile creation and edition Feb 27, 2019

@alexbarnsley alexbarnsley merged commit f3bd276 into ArkEcosystem:develop Feb 28, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@j-a-m-l j-a-m-l deleted the j-a-m-l:move-chart-on-dashboard-to-profile-settings branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.