Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display the ticker price on the dashboard, even when the chart is disabled #1092

Merged
merged 2 commits into from Feb 27, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 21, 2019

Proposed changes

Since some users may disable the chart for performance reasons, as a trading attitude/technique, etc. showing the price might be helpful for them.

The price is requested periodically unless is disabled on the network configuration, so displaying the price doesn't involve additional requests.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 21, 2019

Codecov Report

Merging #1092 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1092      +/-   ##
===========================================
- Coverage    40.34%   40.31%   -0.04%     
===========================================
  Files          207      207              
  Lines         5242     5246       +4     
  Branches      1033     1033              
===========================================
  Hits          2115     2115              
- Misses        3013     3017       +4     
  Partials       114      114
Impacted Files Coverage Δ
...derer/components/MarketChart/MarketChartHeader.vue 50% <ø> (-16.67%) ⬇️
src/renderer/pages/Dashboard.vue 21.05% <100%> (-3.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495a1b2...4cd1d36. Read the comment docs.

@luciorubeens luciorubeens merged commit 92c66ce into ArkEcosystem:develop Feb 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.