Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: speed session load up by using 1 mutation instead of dispatching lots of actions #1093

Merged
merged 1 commit into from Feb 21, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 21, 2019

Proposed changes

This change reduces the time to load initially the session about 2 seconds and switching profiles is reduced about 1 second. Your mileage may vary.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 21, 2019

Codecov Report

Merging #1093 into develop will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1093      +/-   ##
===========================================
+ Coverage    40.29%   40.33%   +0.04%     
===========================================
  Files          207      207              
  Lines         5251     5243       -8     
  Branches      1035     1033       -2     
===========================================
- Hits          2116     2115       -1     
+ Misses        3020     3014       -6     
+ Partials       115      114       -1
Impacted Files Coverage Δ
src/renderer/store/modules/session.js 35.51% <0%> (-0.34%) ⬇️
src/renderer/components/Network/NetworkModal.vue 3.59% <0%> (-0.63%) ⬇️
src/renderer/services/crypto-compare.js 80% <0%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a0d7c...17cd993. Read the comment docs.

@luciorubeens luciorubeens merged commit 34022f0 into ArkEcosystem:develop Feb 21, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@j-a-m-l j-a-m-l deleted the j-a-m-l:faster-session-load branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.