Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile portal-vue to not display developer note in production #1095

Merged
merged 1 commit into from Feb 22, 2019

Conversation

@luciorubeens
Copy link
Member

commented Feb 22, 2019

Proposed changes

In the production version is showing the developer note:

captura de tela 2019-02-22 as 11 37 48

Types of changes

  • Build (changes that affect the build system)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

@alexbarnsley @j-a-m-l - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l
Copy link
Contributor

left a comment

Good catch, @luciorubeens.

@j-a-m-l j-a-m-l merged commit 09c4467 into develop Feb 22, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/portal-vue branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.