Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: compile portal-vue to not display developer note in production #1095

Merged
merged 1 commit into from Feb 22, 2019

Conversation

luciorubeens
Copy link
Contributor

Proposed changes

In the production version is showing the developer note:

captura de tela 2019-02-22 as 11 37 48

Types of changes

  • Build (changes that affect the build system)

@ghost
Copy link

ghost commented Feb 22, 2019

@alexbarnsley @j-a-m-l - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Feb 22, 2019
Copy link
Contributor

@j-a-m-l j-a-m-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @luciorubeens.

@j-a-m-l j-a-m-l merged commit 09c4467 into develop Feb 22, 2019
@ghost ghost deleted the fix/portal-vue branch February 22, 2019 19:02
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants