Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saving of invalid profile name on leave #1101

Merged
merged 11 commits into from May 31, 2019

Conversation

@kalgoop
Copy link
Contributor

commented Feb 25, 2019

When you leave profile edition page and click save option when leaving, this saves profile even if the profile name is duplicate

Proposed changes

Save changes if profile name isn't a duplicate

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@kalgoop Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@alexbarnsley @j-a-m-l @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 25, 2019

Codecov Report

Merging #1101 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
- Coverage    40.17%   40.13%   -0.04%     
===========================================
  Files          231      231              
  Lines         6362     6368       +6     
  Branches      1246     1248       +2     
===========================================
  Hits          2556     2556              
- Misses        3585     3591       +6     
  Partials       221      221
Impacted Files Coverage Δ
src/renderer/pages/Profile/ProfileEdition.vue 8.66% <ø> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d948a...4453fd0. Read the comment docs.

refactor: dont disable save button when profile name valid
even when the 'isNameEditable' don't disable save button. Instead disable it only when the name has an error.
@alexbarnsley
Copy link
Member

left a comment

Thanks @kalgoop. This certainly fixes the issue, but I believe it provides a poor user experience. It needs to tell the user either on the "ignore" confirmation or when when they choose "No, save them" that it wasn't able to save the name due to an error with the name that they chose. Could you change this please.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@kalgoop Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

kalgoop added some commits Mar 1, 2019

@kalgoop

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

@alexbarnsley Showing an error when fails to update profile name

@kalgoop kalgoop changed the title bugfix: saving of invalid profile editions bugfix: saving of invalid profile edits Mar 2, 2019

@faustbrian faustbrian requested a review from alexbarnsley Apr 22, 2019

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@alexbarnsley this PR has been updated, does it meet your expectations?

@j-a-m-l j-a-m-l requested a review from ItsANameToo as a code owner Apr 30, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented May 3, 2019

I'll take a look after the next release. Thanks for the ping @j-a-m-l

@alexbarnsley alexbarnsley self-assigned this May 3, 2019

alexbarnsley and others added some commits May 27, 2019

alexbarnsley added some commits May 31, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented May 31, 2019

I've made some changes @kalgoop - will merge once tests pass

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 31, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@alexbarnsley alexbarnsley changed the title bugfix: saving of invalid profile edits fix: saving of invalid profile name on leave May 31, 2019

@alexbarnsley alexbarnsley merged commit 719e259 into ArkEcosystem:develop May 31, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

alexbarnsley added a commit that referenced this pull request Jun 26, 2019

chore: merge develop to master (#1304)
* fix: improve validation for epoch format (#1164)

* chore: upgrade Vue and other dependencies and use Node 11 on CI (#1160)

* feat: allow using a pool of background workers and use create a unified HTTP client (#1120)

* fix: `InputSelect` dropdowns (#1174)

* fix: `InputSelect` dropdowns

* refactor: use the new Vue 2.6 syntax for named slots

* fix: do not allow more than 1 `InputSelect` open at the same time

* fix: other network fees when higher than ARK default static fees (#1172)

* fix: main sidebar menus (settings and peers/networks) (#1175)

* fix: the wallet selection dropdown and the wallet sidebar filters (#1184)

* fix: do not fail when navigating to other page while loading transactions (#1185)

* fix: use of getStruct in ledger transactions (#1190)

* chore: add ItsANameToo as code owner

* fix: add network modal validation (#1173)

* fix: network validation being overwritten

* feat: pull active delegates from api

* fix: make sure active delegates value exists

* refactor: improve server regex

* test: network modal for adding network

* chore: replace todo with comment

* fix: use one loop with prefilled values as backup

* refactor: allow string or number for input text

* refactor: allow fetching fees for specific network

* fix: fetch network fees when adding/editing

* fix: fetch fees & wait before add/update

* chore: remove mario from contributors (#1196)

* chore: add Altilly Exchange Wallet (#1199)

* fix: align the add profile placeholder (#1202)

* fix: days on the X axis of the market chart (#1203)

* fix: fetch fees only if the network is available (#1206)

* fix: stop hover from displacing address container (#1242)

* fix: vue-i18n-extract commands (#1247)

* refactor: require user action when generating 2nd passphrase (#1229)

* feat: store sidebar sorting and filters (#1148)

* feat: add option to hide the wallet button text (#1146)

* fix: get children of TransitionGroup when available & word-break of vendorfield (#1234)

* feat: show remaining bytes in vendorfield helper text (#1259)

* chore: use organization-wide GitHub Configuration (#1267)

* misc: Italian language update (#1268)

* fix: tidy permission method names & check exists (#1260)

* feat: add option to export wallets (#1244)

* feat: use the theme colours for the wallet filters instead of white (#1270)

* deps: upgrade `axios` (CVE-2019-10742) (#1271)

* fix: saving of invalid profile name on leave (#1101)

* bugfix: saving of invalid profile editions

* refactor: dont disable save button when profile name valid

even when the 'isNameEditable' don't disable save button. Instead disable it only when the name has an error.

* Update en-US.js

* Update ProfileEdition.vue

* refactor: show failed update message on close

* refactor: add update failure reason

* fix: disable both save buttons if name invalid

* fix: display the wallet sidebar filters on the right position (#1201)

* fix: highlight filters button when expanded if active

* fix: display the wallet sidebar filters on the right position

* refactor: add the status icon and plus/minus sign in the transaction show modal (#1272)

* fix: use webview instead of iframe for changelly (#1277)

* revert: worker changes from commit e42290

* refactor: use nock to mock tests (#1291)

* fix: add options mock requests

* fix: tests not mocking api

* fix: duplicated key warning on `WalletNew`

* Update src/renderer/pages/Wallet/WalletNew.vue

Co-Authored-By: Edgar Goetzendorff <hello@dated.fun>

* fix: ledger options on build (#1300)

* fix: ledger options on build

* fix: use component directly

* fix: change order of arguments in uniqBy call (#1297)

* fix: don't close custom peer modal when clicking inside (#1204)

* refactor: rename `NetworkCustomPeer` to `NetworkCustomPeerModal`

* fix: do not close the custom peer modal when clicking inside it

* refactor: wallet address & balance clickable on WalletAll page (#1301)

* fix: ledger wallet sidebar filter (#1292)

* fix: ledger whitescreen (#1296)

* fix: ledger whitescreen errors

* refactor: all ledger errors are failures

* refactor: improve ledger connection check

* refactor: improve ledger & use hid-singleton

* test: fix failing

* chore: remove e2e tests

* fix: open transaction modal on dashboard (#1281)

* fix: remove deeplink validation prefix

* fix: open transaction modal on dashboard

* fix: don't switch twice when selecting wallet on WalletSidebar (#1302)

* chore: bump version to 2.5.0 (#1303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.