Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stage linted files before commit #1102

Merged
merged 1 commit into from Feb 26, 2019

Conversation

@dated
Copy link
Contributor

commented Feb 25, 2019

Proposed changes

Adds the git add command to the lint-staged config, to include linted files in commits.

Types of changes

  • Other... Please describe: config

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@alexbarnsley @j-a-m-l @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

@luciorubeens @alexbarnsley do you like the idea?

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

The reason behind this is that it's very easy to push un-linted files with the current setup.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

I understand, but maybe others don't like the idea of pushing code that has been altered by a linter without being reviewed: currently you have to accept the suggestions manually, so you are aware of the changes.

Since this change would affect the workflow of all the devs, asking to the rest of maintainers is a must.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

Since this change would affect the workflow of all the devs, asking to the rest of maintainers is a must.

Sure! Just wanted to explain myself :D the core repository uses the setup proposed here, but it's a matter of personal preference in the end.

@luciorubeens
Copy link
Member

left a comment

Sounds good to me

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@dated A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@luciorubeens luciorubeens merged commit 5528ae2 into ArkEcosystem:develop Feb 26, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@dated Your pull request has been merged but was not assigned a bounty tier. @alexbarnsley @j-a-m-l @luciorubeens - please assign a bounty tier to this pull request in the next few days.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@dated Your pull request has been merged and marked as tier 5. It will earn you $5 USD.

@dated dated deleted the dated:add-linted-files branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.