Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore the case of the query when filtering by name of wallets, contacts, Ledgers, known wallets or delegates #1104

merged 2 commits into from Feb 27, 2019


Copy link

commented Feb 25, 2019

Proposed changes

The case of addresses wouldn't be ignored.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Test (adding missing tests or fixing existing tests)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

This comment has been minimized.

Copy link

commented Feb 25, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.


This comment has been minimized.

Copy link

commented Feb 25, 2019

Codecov Report

Merging #1104 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1104      +/-   ##
+ Coverage     40.2%   40.25%   +0.04%     
  Files          207      207              
  Lines         5255     5259       +4     
  Branches      1033     1028       -5     
+ Hits          2113     2117       +4     
- Misses        3026     3027       +1     
+ Partials       116      115       -1
Impacted Files Coverage Δ
.../components/Wallet/WalletSidebar/WalletSidebar.vue 61.97% <ø> (+2.27%) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0e460...282623e. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 40f04ce into develop Feb 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the ignore-case-on-sidebar-filters branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.