Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight the wallet sidebar filters button when they are active #1105

Merged
merged 1 commit into from Feb 27, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 26, 2019

Proposed changes

This is a measure to avoid that users forget that they have activated some filters and start wondering where are their wallets.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 26, 2019

Codecov Report

Merging #1105 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1105      +/-   ##
===========================================
+ Coverage     40.2%   40.22%   +0.01%     
===========================================
  Files          207      207              
  Lines         5255     5256       +1     
  Branches      1033     1027       -6     
===========================================
+ Hits          2113     2114       +1     
- Misses        3026     3027       +1     
+ Partials       116      115       -1
Impacted Files Coverage Δ
.../components/Wallet/WalletSidebar/WalletSidebar.vue 60.29% <ø> (+0.59%) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0e460...1ac7589. Read the comment docs.

@alexbarnsley
Copy link
Member

left a comment

👍

@j-a-m-l j-a-m-l merged commit 13e16e9 into develop Feb 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the highlight-active-filters branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.