Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: request wallets data and transactions in parallel during synchronization #1106

Merged
merged 5 commits into from Feb 27, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 27, 2019

Proposed changes

This is another step towards a faster app.

In this case, requesting the wallet data and transactions in parallel should save those 1 or 2 seconds, at minimum, of getting first the wallet data. This is not really perceptible on the first load because it's too slow yet, but it would be saved every time that the wallet or transactions are checked.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l j-a-m-l merged commit 4d9e50f into develop Feb 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the parallel-synch branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.