Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request multiple wallets or transactions at once when the API allows it #1107

Merged
merged 4 commits into from Feb 27, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 27, 2019

Proposed changes

Using the new endpoints that allow searching multiple wallets or transactions at the same time wasn't correctly triggered on the first load and when changing peers.

Apart from that, I've refactored the client service to make it easier using the new features that are being added to the API, and I've refactor slightly the tests to make them more readable.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 27, 2019

Codecov Report

Merging #1107 into develop will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1107      +/-   ##
===========================================
- Coverage    40.22%   40.16%   -0.07%     
===========================================
  Files          207      207              
  Lines         5261     5244      -17     
  Branches      1026     1028       +2     
===========================================
- Hits          2116     2106      -10     
+ Misses        3030     3023       -7     
  Partials       115      115
Impacted Files Coverage Δ
src/renderer/store/modules/peer.js 69.3% <100%> (+0.14%) ⬆️
src/renderer/services/client.js 70.62% <64.28%> (+0.62%) ⬆️
...rc/renderer/components/MarketChart/MarketChart.vue 21.79% <0%> (-9.67%) ⬇️
src/renderer/mixins/formatter.js 76.92% <0%> (-6.42%) ⬇️
src/renderer/services/synchronizer/wallets.js 66.66% <0%> (-1.63%) ⬇️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️
src/renderer/components/Wallet/WalletTable.vue 18.18% <0%> (+2.18%) ⬆️
src/renderer/pages/Dashboard.vue 23.52% <0%> (+3.52%) ⬆️
...derer/components/MarketChart/MarketChartHeader.vue 66.66% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942385a...0380dfd. Read the comment docs.

@alexbarnsley
Copy link
Member

left a comment

Looks good, didn't experience any issues 👍

@j-a-m-l j-a-m-l merged commit e508c04 into develop Feb 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-searching-for-multiple-at-once branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.