Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not store Ledger connection timer since it is not used #1118

merged 4 commits into from Mar 18, 2019


Copy link

commented Mar 7, 2019

Proposed changes

This PR refactors Ledger-related code.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #1118 into develop will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1118      +/-   ##
- Coverage    41.06%   41.05%   -0.02%     
  Files          215      215              
  Lines         5481     5473       -8     
  Branches      1064     1063       -1     
- Hits          2251     2247       -4     
+ Misses        3106     3102       -4     
  Partials       124      124
Impacted Files Coverage Δ
src/renderer/store/modules/ledger.js 75.75% <33.33%> (+1%) ⬆️
src/renderer/services/ledger-service.js 88.88% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a49f5b...b69d976. Read the comment docs.

@luciorubeens luciorubeens merged commit 7887e62 into develop Mar 18, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the ledger-not-save-timer branch Mar 18, 2019

luciorubeens added a commit that referenced this pull request Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.