Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: delay and change the interval of synchronization #1121

Merged
merged 4 commits into from Mar 13, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Mar 12, 2019

Proposed changes

This PR delays some synchronizer actions to not process all the requested data at the same time and changes the intervals to reduce the frequency of requests.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

The ci/circleci: test-node-11 job is failing as of 31f9962bd7201fd90186f17757cdc2a98273aab4. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

commented Mar 13, 2019

Codecov Report

Merging #1121 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1121      +/-   ##
===========================================
- Coverage    41.19%   41.17%   -0.02%     
===========================================
  Files          213      213              
  Lines         5443     5445       +2     
  Branches      1059     1060       +1     
===========================================
  Hits          2242     2242              
- Misses        3080     3081       +1     
- Partials       121      122       +1
Impacted Files Coverage Δ
src/renderer/services/synchronizer.js 21.21% <0%> (ø) ⬆️
src/renderer/App.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9b604...d8c79d7. Read the comment docs.

@luciorubeens luciorubeens merged commit ba8ec78 into develop Mar 13, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the change-synch-intervals branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.