Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: truncate the transaction block ID on the transaction show modal if necessary #1129

merged 3 commits into from Mar 21, 2019


Copy link

commented Mar 15, 2019

Proposed changes

Block ID is going to change to sha256, so in some cases, it will be too long to display it on the transaction show modal.

Types of changes

  • New feature (non-breaking change which adds functionality)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

This comment has been minimized.

Copy link

commented Mar 15, 2019

Codecov Report

Merging #1129 into develop will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1129   +/-   ##
  Coverage    41.08%   41.08%           
  Files          215      215           
  Lines         5476     5476           
  Branches      1064     1069    +5     
  Hits          2250     2250           
+ Misses        3102     3101    -1     
- Partials       124      125    +1
Impacted Files Coverage Δ
...enderer/components/Transaction/TransactionShow.vue 43.75% <66.66%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f6e81...b771d4e. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 60d3085 into develop Mar 21, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the sha256-block-ids branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.