Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable the translation of empty transaction table message #1132

Merged
merged 3 commits into from Mar 18, 2019

Conversation

@danielstc
Copy link
Contributor

commented Mar 15, 2019

Proposed changes

If another language is chosen, the

No transactions have been found. The latest transactions will be displayed here.

messages translations are not working.

Adds:
:no-data-message="$t('TABLE.NO_TRANSACTIONS')"

in:

  1. src/renderer/components/Dashboard/DashboardTransactions.vue

  2. src/renderer/components/Transaction/TransactionTable.vue

Types of changes

  • [x ] Bugfix (non-breaking change which fixes an issue)

Checklist

danielstc added some commits Mar 15, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@danielstc danielstc changed the title Fix/display no-transactions message fix: enables the translation of missing messages Mar 15, 2019

@luciorubeens

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Hey @danielstc, sounds good! but 3 days ago there was an interruption in CircleCI and your test did not run

@danielstc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

Hi @luciorubeens. Ok. I have to do something? Let me know.

@luciorubeens

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

@danielstc Yes, try sending an empty commit or check your CircleCI account to re-run

@codecov-io

This comment has been minimized.

Copy link

commented Mar 18, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@2c9b19a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1132   +/-   ##
==========================================
  Coverage           ?   40.96%           
==========================================
  Files              ?      215           
  Lines              ?     5454           
  Branches           ?     1062           
==========================================
  Hits               ?     2234           
  Misses             ?     3097           
  Partials           ?      123
Impacted Files Coverage Δ
...rer/components/Dashboard/DashboardTransactions.vue 80% <ø> (ø)
...nderer/components/Transaction/TransactionTable.vue 18.18% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9b19a...43a810c. Read the comment docs.

@j-a-m-l j-a-m-l changed the title fix: enables the translation of missing messages fix: enable the translation of empty transaction table message Mar 18, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@luciorubeens luciorubeens merged commit 21ca9de into ArkEcosystem:develop Mar 18, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

@luciorubeens

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Fixed by updating the branch, thanks!

@danielstc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@luciorubeens perfect! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.