Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: cache all the pages that do not use a parametrized URL #1135

Merged
merged 7 commits into from Mar 22, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Mar 18, 2019

Proposed changes

Cache all the pages that don't depend on parameters on the URL by using a trick:
Since, in those cases, the URL is the same, it's possible to keep alive the component, because 1 component name is bound to 1 route name.
In cases, such as the wallet page, that property doesn't hold, so, it's not possible to use this mechanism.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@j-a-m-l j-a-m-l force-pushed the cache-profile-dependent-pages branch from fdc68ba to 67f0b84 Mar 22, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #1135 into develop will decrease coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1135      +/-   ##
===========================================
- Coverage    41.08%   40.83%   -0.26%     
===========================================
  Files          215      215              
  Lines         5476     5491      +15     
  Branches      1064     1076      +12     
===========================================
- Hits          2250     2242       -8     
- Misses        3102     3124      +22     
- Partials       124      125       +1
Impacted Files Coverage Δ
src/renderer/pages/Profile/ProfileNew.vue 7.5% <ø> (-0.3%) ⬇️
src/renderer/pages/Wallet/WalletAll.vue 40% <ø> (-9.37%) ⬇️
src/renderer/pages/Contact/ContactAll.vue 17.14% <0%> (+0.86%) ⬆️
src/renderer/App.vue 0% <0%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d3085...cac0f7b. Read the comment docs.

@j-a-m-l j-a-m-l changed the title [WIP] perf: cache all the pages that do not use a parametrized URL perf: cache all the pages that do not use a parametrized URL Mar 22, 2019

@alexbarnsley alexbarnsley merged commit 431c78a into develop Mar 22, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the cache-profile-dependent-pages branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.