Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: static fee default if fee statistics empty #1139

Merged
merged 3 commits into from Mar 20, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Mar 19, 2019

Proposed changes

If fee statistics from a network are empty, an error occurrs with the InputFee component which resulted in the component failing to load. This was noticed when using v2.3 of the wallet with newly deployed chains.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@codecov-io

This comment has been minimized.

Copy link

commented Mar 19, 2019

Codecov Report

Merging #1139 into develop will increase coverage by 0.15%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1139      +/-   ##
===========================================
+ Coverage    41.05%   41.21%   +0.15%     
===========================================
  Files          215      213       -2     
  Lines         5473     5452      -21     
  Branches      1063     1067       +4     
===========================================
  Hits          2247     2247              
+ Misses        3102     3082      -20     
+ Partials       124      123       -1
Impacted Files Coverage Δ
src/renderer/components/Input/InputFee.vue 69.51% <66.66%> (-0.11%) ⬇️
src/renderer/services/synchronizer/wallets.js 63.73% <0%> (-7.7%) ⬇️
src/renderer/App.vue 0% <0%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️
src/renderer/router/index.js 100% <0%> (ø) ⬆️
src/renderer/components/Search/index.js
...c/renderer/components/Search/SearchFilter/index.js
src/renderer/store/modules/ledger.js 75.86% <0%> (+0.1%) ⬆️
src/renderer/store/modules/wallet.js 52.05% <0%> (+6.27%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7887e62...8d919e1. Read the comment docs.

alexbarnsley added some commits Mar 19, 2019

@luciorubeens luciorubeens merged commit f6f6e81 into develop Mar 20, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/fee-statistics-new-chain branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.