Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable market chart setting if market not enabled #1140

Merged
merged 5 commits into from Mar 25, 2019

Conversation

@dated
Copy link
Contributor

commented Mar 19, 2019

Proposed changes

The profile edition page allows to change the value for the market chart display even if no market is available, for instance on devnet.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l
Copy link
Contributor

left a comment

Currently it's not easy to spot that is disabled. Try:

  1. Change the style/colour so it's more easy to spot it
  2. Use the not-allowed cursor
@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@dated

[Vue warn]: Invalid prop: type check failed for prop "itemLabelClass". Expected String with value "[object Object]", got Object 

found in

---> <ListDividedItem> at src/renderer/components/ListDivided/ListDividedItem.vue
       <ListDivided> at src/renderer/components/ListDivided/ListDivided.vue
         <MenuTabItem> at src/renderer/components/Menu/MenuTab/MenuTabItem.vue
           <MenuTab> at src/renderer/components/Menu/MenuTab/MenuTab.vue
             <ProfileEdition> at src/renderer/pages/Profile/ProfileEdition.vue
               <DesktopWallet> at src/renderer/App.vue
                 <Root>

dated added some commits Mar 20, 2019

@j-a-m-l
Copy link
Contributor

left a comment

Thanks, @dated.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit e35c2cd into ArkEcosystem:develop Mar 25, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

@dated dated deleted the dated:disable-chart-setting branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.