Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close transaction show modal when clicking on addresses and navigate to transactions tab always #1143

Open
wants to merge 9 commits into
base: develop
from

Conversation

Projects
None yet
5 participants
@j-a-m-l
Copy link
Contributor

commented Mar 19, 2019

Proposed changes

Changed the transaction modal to, when clicking on an address, close itself and navigate to that address, to the transactions tab instead of the current tab (which could be delegates, for example).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@j-a-m-l j-a-m-l changed the title fix: close transaction show when clicking on and address and navigate to transactions tab always fix: close transaction show modal when clicking on addresses and navigate to transactions tab always Mar 19, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Doesn't seem to be working for me 🤔 I click on a wallet, go to delegates, click on the name and it closes the popup and loads the new wallet, but I'm still on the delegates tab. What's interesting is that I cannot then click on a delegate again, I have to go to the wallet list and back into the wallet. It's strange. No errors in devtools. I guess I can't click a delegate because I'm not on one of my wallets - if this is intended then perhaps we need to disable the pointer cursor on mouse over.

The popup does close though when clicking an address from the transactions list which is working 👌 although the tooltip doesn't seem to disappear which I just noticed (it moves to the top-left):

image

@codecov-io

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@961f144). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1143   +/-   ##
==========================================
  Coverage           ?   39.91%           
==========================================
  Files              ?      228           
  Lines              ?     6343           
  Branches           ?     1246           
==========================================
  Hits               ?     2532           
  Misses             ?     3590           
  Partials           ?      221
Impacted Files Coverage Δ
...ts/Transaction/TransactionForm/TransactionForm.vue 46.15% <ø> (ø)
.../components/Wallet/WalletDetails/WalletDetails.vue 9.09% <ø> (ø)
...ransaction/TransactionForm/TransactionFormVote.vue 12.22% <ø> (ø)
...nderer/components/Transaction/TransactionModal.vue 33.33% <ø> (ø)
src/renderer/components/Wallet/WalletAddress.vue 48.48% <ø> (ø)
...enderer/components/Transaction/TransactionShow.vue 47.05% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961f144...e241ca3. Read the comment docs.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@alexbarnsley this change was intended initially for the transaction modal (TransactionShow), but it looks like you were trying the vote modal. I've changed it too.

About the tooltip, I've fixed that, although it's possible to see it during some ms. while it's closing. I guess that it's related to how the library works internally.

IMHO, this section should be changed to not be so confused, with examples like the 1 you said (I can click on the delegate on my wallet, but I can't click on other wallet) or others such as displaying the contacts in some occasions and my wallets on others.

j-a-m-l and others added some commits Mar 28, 2019

@faustbrian faustbrian requested a review from ItsANameToo as a code owner May 27, 2019

j-a-m-l added some commits Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.