Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store sidebar sorting and filters #1148

Merged
merged 14 commits into from May 17, 2019

Conversation

@dated
Copy link
Contributor

commented Mar 22, 2019

Proposed changes

Closes #1137.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

dated and others added some commits Mar 26, 2019

@j-a-m-l
Copy link
Contributor

left a comment

@dated, there are several TypeError and other problems on the console.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Ah, finally found what you are seeing. There's a problem with existing profiles.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Should be fixed now @j-a-m-l.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@dated sorting preferences are stored, but not the activated filters.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Right. I'll have a look at those later today.

@dated dated changed the title feat: store sidebar sorting option [WIP] feat: store sidebar sorting and filters Mar 28, 2019

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

I'd exclude the search query from the stored filters, do you agree @j-a-m-l?

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Yes, apart from that, it's necessary to highlight more that filters are active, so when a user backs after several days he could recognize that.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

The ci/circleci: test-node-11 job is failing as of 340464c9a2f9695c58e49f231c17cca5a6df8024. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

I'll add a little notice to the dashboard sidebar to indicate that filters are active, as currently there is no such warning. Other than that there is a noticeable delay currently when changing the sort order or applying filters, as the whole profile gets updated. If possible that should be refactored as to update only the changed values and thus increase performance.

@dated dated changed the title [WIP] feat: store sidebar sorting and filters feat: store sidebar sorting and filters May 4, 2019

@dated

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

One thing that's missing is a notification on the dashboard, as there is no indicator of wether there are any active filters.

The best solution would be to display a respective notification on a per session basis imho, with the option to never display it again. Thoughts @alexbarnsley / @j-a-m-l?

@dated dated changed the title feat: store sidebar sorting and filters [WIP] feat: store sidebar sorting and filters May 13, 2019

@dated

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Something like so:

image

@olejegcord what do you think?

@olejegcord

This comment has been minimized.

Copy link

commented May 16, 2019

Maybe a good idea, but there are a questions. How will the user understand which filters we are talking about? I don't know which filters we're talking about, because this block should display all the wallets 🤔

@dated

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Currently the sidebar on the dashboard shows the filtered wallets, not the whole list. The filters can be applied on the wallets page. As this warning shows only when the user has activated one or more filters, he will likely understand what is meant by that.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

The wording can be adjusted of course, this draft is more about the design and the concept behind it :)

@olejegcord

This comment has been minimized.

Copy link

commented May 16, 2019

I think it's best to do a pop-up notification in the right corner. Since the sidebar will change in the future.
In the notification, place your action buttons
I draw, give me 15 min

@olejegcord

This comment has been minimized.

Copy link

commented May 16, 2019

like this
image

@zillionn

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

Btw it's kind of strange that there is such filter on the right panel when inside some wallet, but there is none on the actual My Wallets page.

And about the active filters. It's common to change the color/appearance of the filter icon when active. You could change its color, add small checkbox above it or the number of active filters:
newmScreenshot 2019-05-17 at 10 37 55

@dated

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

The filter icon becomes red if a filter has been activated actually. I don't like the popup too much as it is way to prominent imho and it enforces an interaction with the user - it can't be ignored. I'm trying some different ideas with the simplest being a floating icon with a tooltip on the pages where the filters cannot be modified.

@zillionn

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

You could just add a one line message above the wallets, something like this:
Screenshot 2019-05-17 at 10 54 04

@olejegcord

This comment has been minimized.

Copy link

commented May 17, 2019

Stop. If we're talking about this filter http://prntscr.com/npqv3r (this filter only touches the inside of the wallet.)
it's not like he shouldn't be influencing this block http://prntscr.com/npqw4m

@dated

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

That settles it, I'll refactor it accordingly.

@dated dated changed the title [WIP] feat: store sidebar sorting and filters feat: store sidebar sorting and filters May 17, 2019

@j-a-m-l
Copy link
Contributor

left a comment

Thanks, @dated.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 17, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit 74af1ba into ArkEcosystem:develop May 17, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Your pull request has been merged and marked as tier 1. It will earn you $100 USD.

@dated dated deleted the dated:feat/store-sidebar-filtering branch May 17, 2019

alexbarnsley added a commit that referenced this pull request Jun 26, 2019

chore: merge develop to master (#1304)
* fix: improve validation for epoch format (#1164)

* chore: upgrade Vue and other dependencies and use Node 11 on CI (#1160)

* feat: allow using a pool of background workers and use create a unified HTTP client (#1120)

* fix: `InputSelect` dropdowns (#1174)

* fix: `InputSelect` dropdowns

* refactor: use the new Vue 2.6 syntax for named slots

* fix: do not allow more than 1 `InputSelect` open at the same time

* fix: other network fees when higher than ARK default static fees (#1172)

* fix: main sidebar menus (settings and peers/networks) (#1175)

* fix: the wallet selection dropdown and the wallet sidebar filters (#1184)

* fix: do not fail when navigating to other page while loading transactions (#1185)

* fix: use of getStruct in ledger transactions (#1190)

* chore: add ItsANameToo as code owner

* fix: add network modal validation (#1173)

* fix: network validation being overwritten

* feat: pull active delegates from api

* fix: make sure active delegates value exists

* refactor: improve server regex

* test: network modal for adding network

* chore: replace todo with comment

* fix: use one loop with prefilled values as backup

* refactor: allow string or number for input text

* refactor: allow fetching fees for specific network

* fix: fetch network fees when adding/editing

* fix: fetch fees & wait before add/update

* chore: remove mario from contributors (#1196)

* chore: add Altilly Exchange Wallet (#1199)

* fix: align the add profile placeholder (#1202)

* fix: days on the X axis of the market chart (#1203)

* fix: fetch fees only if the network is available (#1206)

* fix: stop hover from displacing address container (#1242)

* fix: vue-i18n-extract commands (#1247)

* refactor: require user action when generating 2nd passphrase (#1229)

* feat: store sidebar sorting and filters (#1148)

* feat: add option to hide the wallet button text (#1146)

* fix: get children of TransitionGroup when available & word-break of vendorfield (#1234)

* feat: show remaining bytes in vendorfield helper text (#1259)

* chore: use organization-wide GitHub Configuration (#1267)

* misc: Italian language update (#1268)

* fix: tidy permission method names & check exists (#1260)

* feat: add option to export wallets (#1244)

* feat: use the theme colours for the wallet filters instead of white (#1270)

* deps: upgrade `axios` (CVE-2019-10742) (#1271)

* fix: saving of invalid profile name on leave (#1101)

* bugfix: saving of invalid profile editions

* refactor: dont disable save button when profile name valid

even when the 'isNameEditable' don't disable save button. Instead disable it only when the name has an error.

* Update en-US.js

* Update ProfileEdition.vue

* refactor: show failed update message on close

* refactor: add update failure reason

* fix: disable both save buttons if name invalid

* fix: display the wallet sidebar filters on the right position (#1201)

* fix: highlight filters button when expanded if active

* fix: display the wallet sidebar filters on the right position

* refactor: add the status icon and plus/minus sign in the transaction show modal (#1272)

* fix: use webview instead of iframe for changelly (#1277)

* revert: worker changes from commit e42290

* refactor: use nock to mock tests (#1291)

* fix: add options mock requests

* fix: tests not mocking api

* fix: duplicated key warning on `WalletNew`

* Update src/renderer/pages/Wallet/WalletNew.vue

Co-Authored-By: Edgar Goetzendorff <hello@dated.fun>

* fix: ledger options on build (#1300)

* fix: ledger options on build

* fix: use component directly

* fix: change order of arguments in uniqBy call (#1297)

* fix: don't close custom peer modal when clicking inside (#1204)

* refactor: rename `NetworkCustomPeer` to `NetworkCustomPeerModal`

* fix: do not close the custom peer modal when clicking inside it

* refactor: wallet address & balance clickable on WalletAll page (#1301)

* fix: ledger wallet sidebar filter (#1292)

* fix: ledger whitescreen (#1296)

* fix: ledger whitescreen errors

* refactor: all ledger errors are failures

* refactor: improve ledger connection check

* refactor: improve ledger & use hid-singleton

* test: fix failing

* chore: remove e2e tests

* fix: open transaction modal on dashboard (#1281)

* fix: remove deeplink validation prefix

* fix: open transaction modal on dashboard

* fix: don't switch twice when selecting wallet on WalletSidebar (#1302)

* chore: bump version to 2.5.0 (#1303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.