Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: store sidebar sorting and filters #1148
Types of changes
requested review from
Mar 22, 2019
I'll add a little notice to the dashboard sidebar to indicate that filters are active, as currently there is no such warning. Other than that there is a noticeable delay currently when changing the sort order or applying filters, as the whole profile gets updated. If possible that should be refactored as to update only the changed values and thus increase performance.
Currently the sidebar on the dashboard shows the filtered wallets, not the whole list. The filters can be applied on the wallets page. As this warning shows only when the user has activated one or more filters, he will likely understand what is meant by that.
Btw it's kind of strange that there is such filter on the right panel when inside some wallet, but there is none on the actual
The filter icon becomes red if a filter has been activated actually. I don't like the popup too much as it is way to prominent imho and it enforces an interaction with the user - it can't be ignored. I'm trying some different ideas with the simplest being a floating icon with a tooltip on the pages where the filters cannot be modified.