Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger issues #1152

Merged
merged 7 commits into from Mar 25, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Mar 24, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Resolves #1151

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@alexbarnsley

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

For reference: fix: wallet sync with ledger - fixes unit tests for wallet.spec.js (wrong commit message prefix)

@codecov-io

This comment has been minimized.

Copy link

commented Mar 24, 2019

Codecov Report

Merging #1152 into develop will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1152      +/-   ##
===========================================
+ Coverage    40.83%   40.83%   +<.01%     
===========================================
  Files          215      215              
  Lines         5491     5488       -3     
  Branches      1071     1076       +5     
===========================================
- Hits          2242     2241       -1     
+ Misses        3125     3122       -3     
- Partials       124      125       +1
Impacted Files Coverage Δ
src/renderer/App.vue 0% <ø> (ø) ⬆️
src/renderer/store/modules/ledger.js 76.41% <0%> (+0.65%) ⬆️
src/renderer/services/synchronizer/wallets.js 71.42% <100%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f983e...9db49ba. Read the comment docs.

@luciorubeens luciorubeens merged commit a76f03a into develop Mar 25, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/ledger-issues branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.