Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not override the state when updating wallets at once #1154

Merged
merged 3 commits into from Mar 25, 2019

Conversation

Projects
None yet
4 participants
@luciorubeens
Copy link
Member

commented Mar 25, 2019

Proposed changes

#1124 introduced a bug because the endpoint to search for multiple addresses does not return cold wallets in the response.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
@codecov-io

This comment has been minimized.

Copy link

commented Mar 25, 2019

Codecov Report

Merging #1154 into develop will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1154      +/-   ##
===========================================
+ Coverage    40.83%   41.18%   +0.34%     
===========================================
  Files          215      215              
  Lines         5488     5490       +2     
  Branches      1071     1076       +5     
===========================================
+ Hits          2241     2261      +20     
+ Misses        3123     3107      -16     
+ Partials       124      122       -2
Impacted Files Coverage Δ
src/renderer/pages/Wallet/WalletAll.vue 47.56% <ø> (+7.56%) ⬆️
src/renderer/store/modules/ledger.js 83.07% <100%> (+6.66%) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f435e0...9dabe12. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 3ccd2a9 into develop Mar 25, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/ledger-cold-wallet branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.