Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial plugin system implementation #1159

Merged
merged 22 commits into from Mar 28, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Mar 27, 2019

Proposed changes

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

The ci/circleci: test-node-11 job is failing as of f359ca5c12d92b187f8f77ad52b5e4977c9830ab. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

commented Mar 27, 2019

Codecov Report

Merging #1159 into develop will decrease coverage by 2.17%.
The diff coverage is 5.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1159      +/-   ##
===========================================
- Coverage    41.17%   38.99%   -2.18%     
===========================================
  Files          215      221       +6     
  Lines         5491     5836     +345     
  Branches      1072     1156      +84     
===========================================
+ Hits          2261     2276      +15     
- Misses        3109     3369     +260     
- Partials       121      191      +70
Impacted Files Coverage Δ
src/renderer/pages/Profile/ProfileNew.vue 7.14% <ø> (-0.36%) ⬇️
...derer/components/Input/InputGrid/InputGridItem.vue 40% <ø> (ø) ⬆️
src/renderer/store/index.js 87.5% <ø> (ø) ⬆️
src/renderer/models/profile.js 0% <ø> (ø) ⬆️
src/renderer/pages/Profile/ProfileEdition.vue 8.92% <ø> (-0.42%) ⬇️
src/renderer/router/index.js 100% <ø> (ø) ⬆️
src/renderer/components/Profile/ProfileAvatar.vue 80% <ø> (-20%) ⬇️
src/renderer/App.vue 0% <0%> (ø) ⬆️
...components/App/AppSidemenu/AppSidemenuSettings.vue 0% <0%> (ø) ⬆️
.../renderer/components/Selection/SelectionAvatar.vue 11.76% <0%> (-8.24%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a417d6...6086766. Read the comment docs.

@alexbarnsley alexbarnsley changed the base branch from develop to v2.4.0 Mar 27, 2019

@luciorubeens luciorubeens marked this pull request as ready for review Mar 28, 2019

@luciorubeens luciorubeens requested a review from faustbrian as a code owner Mar 28, 2019

@luciorubeens luciorubeens merged commit 2925702 into v2.4.0 Mar 28, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the feat/plugin-manager branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.