Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include the new icon for disconnecting from custom peer #1208

Merged
merged 7 commits into from Apr 30, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Apr 25, 2019

Proposed changes

Apart from resolving #1188, this PR modifies the style to follow @olejegcord suggestion

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Apr 25, 2019

Codecov Report

Merging #1208 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1208   +/-   ##
=======================================
  Coverage   39.28%   39.28%           
=======================================
  Files         223      223           
  Lines        5913     5913           
  Branches     1180     1175    -5     
=======================================
  Hits         2323     2323           
- Misses       3391     3392    +1     
+ Partials      199      198    -1
Impacted Files Coverage Δ
...nents/App/AppSidemenu/AppSidemenuNetworkStatus.vue 0% <0%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 28.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef81b0...fe08f3e. Read the comment docs.

@alexbarnsley
Copy link
Member

left a comment

This breaks the centralisation (vertically and horizontally) of the refresh icon:

Before:
image

After:
image

if it's the case that the button will remain this size, the icon needs re-positioning, and the top-right and bottom-right corners need to be rounded.

@alexbarnsley alexbarnsley self-assigned this Apr 30, 2019

j-a-m-l added some commits Apr 30, 2019

@j-a-m-l j-a-m-l requested a review from alexbarnsley Apr 30, 2019

@alexbarnsley alexbarnsley merged commit e48878d into next Apr 30, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the disconnect-icon branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.