Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network model validation to accept numbers in slip44 #1210

Merged
merged 3 commits into from Apr 30, 2019

Conversation

@luciorubeens
Copy link
Member

commented Apr 26, 2019

Proposed changes

When registering a custom network, an invalid type error is issued.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
@codecov-io

This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #1210 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1210   +/-   ##
=======================================
  Coverage   39.26%   39.26%           
=======================================
  Files         222      222           
  Lines        5903     5903           
  Branches     1176     1176           
=======================================
  Hits         2318     2318           
  Misses       3386     3386           
  Partials      199      199
Impacted Files Coverage Δ
src/renderer/models/network.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398eecd...41be02d. Read the comment docs.

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

I've approved but i don't get this error on the next branch 🤔 how was you adding the network @luciorubeens?

Edit: Nevermind, i do. I was testing with a network that didn't return the slip44 value

@alexbarnsley alexbarnsley merged commit 5c89d9b into next Apr 30, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/slip44-number branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.