Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display more information on the modals for sending transactions #1211

Merged
merged 5 commits into from Apr 29, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Apr 26, 2019

Proposed changes

Resolves #1060

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #1211 into next will decrease coverage by <.01%.
The diff coverage is 64.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1211      +/-   ##
==========================================
- Coverage   39.27%   39.26%   -0.01%     
==========================================
  Files         222      222              
  Lines        5889     5903      +14     
  Branches     1176     1176              
==========================================
+ Hits         2313     2318       +5     
- Misses       3377     3386       +9     
  Partials      199      199
Impacted Files Coverage Δ
...nsaction/TransactionConfirm/TransactionConfirm.vue 25.92% <ø> (ø) ⬆️
...Confirm/TransactionConfirmDelegateRegistration.vue 33.33% <100%> (-6.67%) ⬇️
...ctionConfirm/TransactionConfirmSecondSignature.vue 66.66% <100%> (-33.34%) ⬇️
...tion/TransactionConfirm/TransactionConfirmVote.vue 66.66% <100%> (-33.34%) ⬇️
.../TransactionConfirm/TransactionConfirmTransfer.vue 50% <33.33%> (-50%) ⬇️
...actionForm/TransactionFormDelegateRegistration.vue 13.23% <57.14%> (+1.11%) ⬆️
...TransactionForm/TransactionFormSecondSignature.vue 14.47% <60%> (+0.96%) ⬆️
...action/TransactionForm/TransactionFormTransfer.vue 7.62% <62.5%> (+0.73%) ⬆️
...ransaction/TransactionForm/TransactionFormVote.vue 11.23% <66.66%> (-0.13%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36000cd...dd1da1e. Read the comment docs.

@j-a-m-l j-a-m-l merged commit 398eecd into next Apr 29, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the more-info-on-tx-modals branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.