Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not break letter avatars when switching languages #1214

Merged
merged 3 commits into from Apr 30, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Apr 30, 2019

Proposed changes

On profile creation or edition, letter avatars were broken when switching from one language to another.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #1214 into next will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1214      +/-   ##
==========================================
- Coverage   39.26%   39.25%   -0.02%     
==========================================
  Files         222      222              
  Lines        5903     5905       +2     
  Branches     1176     1177       +1     
==========================================
  Hits         2318     2318              
- Misses       3386     3388       +2     
  Partials      199      199
Impacted Files Coverage Δ
...derer/components/Input/InputGrid/InputGridItem.vue 40% <ø> (ø) ⬆️
.../renderer/components/Input/InputGrid/InputGrid.vue 33.33% <ø> (-4.17%) ⬇️
src/renderer/pages/Profile/ProfileEdition.vue 8.92% <ø> (ø) ⬆️
src/renderer/pages/Profile/ProfileNew.vue 7.14% <ø> (ø) ⬆️
.../renderer/components/Selection/SelectionAvatar.vue 11.76% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398eecd...0ce3498. Read the comment docs.

@alexbarnsley alexbarnsley self-assigned this Apr 30, 2019

@alexbarnsley alexbarnsley merged commit fcb2c0b into next Apr 30, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-selection-avatar-language branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.