Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not allow that the last profile is removed #1215

Merged
merged 2 commits into from Apr 30, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Apr 30, 2019

Proposed changes

Allowing that users remove all profiles provokes lots of inconsistencies on different parts of the application; since users are forced to have 1 profile at least, detecting and solving those inconsistencies and side effects is more problematic than this approach.

What do you think @alexbarnsley and @luciorubeens?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Perhaps a future addition can be to say that a minimum of 1 profile is required. Or to force showing of the initial profile create screen that shows on first launch. However, this can wait and will be done on the next design update from Oleg.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #1215 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1215   +/-   ##
=======================================
  Coverage   39.28%   39.28%           
=======================================
  Files         223      223           
  Lines        5913     5913           
  Branches     1180     1175    -5     
=======================================
  Hits         2323     2323           
- Misses       3391     3392    +1     
+ Partials      199      198    -1
Impacted Files Coverage Δ
src/renderer/pages/Profile/ProfileAll.vue 75.75% <ø> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 28.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48878d...4837062. Read the comment docs.

@alexbarnsley alexbarnsley merged commit d97bf77 into next Apr 30, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the do-not-allow-removing-last-profile branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.