Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger cold wallet send #1216

Merged
merged 3 commits into from Apr 30, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Apr 30, 2019

Proposed changes

This PR fixes an issue where synchronizer updates the public key for ledger wallets when fetching from the API. This removes the public key for cold ledger wallets, meaning it causes an error when trying to send from the wallet.

Fixes #1169.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #1216 into next will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1216      +/-   ##
==========================================
+ Coverage   39.28%   39.28%   +<.01%     
==========================================
  Files         223      223              
  Lines        5913     5915       +2     
  Branches     1175     1181       +6     
==========================================
+ Hits         2323     2324       +1     
  Misses       3392     3392              
- Partials      198      199       +1
Impacted Files Coverage Δ
src/renderer/services/synchronizer/wallets.js 71.02% <50%> (-0.41%) ⬇️
src/renderer/components/Network/NetworkModal.vue 28.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97bf77...729a1ba. Read the comment docs.

@j-a-m-l j-a-m-l merged commit 0d46237 into next Apr 30, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/ledger-cold-wallet-send branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.