Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: username validation when registering a new delegate #1218

Merged
merged 4 commits into from May 3, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented May 2, 2019

Proposed changes

The current @arkecosystem/crypto package (2.2.2) has removed the username validator, which was breaking the delegate registration process.
Following @faustbrian suggestion, instead of upgrading that package, since it'is going to be modified until core 2.6, I've, instead, implemented the validation on the wallet.

Additionally, the confirmation screen has been fixed to display the sender label correctly.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

Update src/renderer/i18n/locales/en-US.js
Co-Authored-By: j-a-m-l <j-a-m-l@users.noreply.github.com>
@codecov-io

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #1218 into next will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1218      +/-   ##
==========================================
+ Coverage   39.28%   39.38%   +0.09%     
==========================================
  Files         223      223              
  Lines        5915     5921       +6     
  Branches     1176     1182       +6     
==========================================
+ Hits         2324     2332       +8     
+ Misses       3393     3391       -2     
  Partials      198      198
Impacted Files Coverage Δ
...actionForm/TransactionFormDelegateRegistration.vue 13.23% <ø> (ø) ⬆️
...Confirm/TransactionConfirmDelegateRegistration.vue 33.33% <ø> (ø) ⬆️
src/renderer/services/wallet.js 36.66% <100%> (+24.16%) ⬆️
src/renderer/components/Network/NetworkModal.vue 28.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39438a5...c86ab67. Read the comment docs.

@luciorubeens luciorubeens merged commit cc81e9b into next May 3, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-delegate-registration branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.