Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer management on v2.4+ #1231

Merged
merged 8 commits into from May 9, 2019

Conversation

@alexbarnsley
Copy link
Member

commented May 9, 2019

Proposed changes

Status is no longer provided in peer lists, which causes issues when trying to connect to peers.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 9, 2019

The ci/circleci: test-node-11 job is failing as of 8640cd8b003016d0c7e9bb952fb7f67822134ae8. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@alexbarnsley alexbarnsley changed the base branch from develop to next May 9, 2019

alexbarnsley added some commits May 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #1231 into next will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next   #1231      +/-   ##
=========================================
- Coverage   38.72%   38.7%   -0.03%     
=========================================
  Files         224     224              
  Lines        6006    6010       +4     
  Branches     1197    1197              
=========================================
  Hits         2326    2326              
- Misses       3470    3474       +4     
  Partials      210     210
Impacted Files Coverage Δ
src/renderer/models/peer.js 100% <ø> (ø) ⬆️
src/renderer/services/client.js 70.35% <0%> (-0.7%) ⬇️
src/renderer/store/modules/peer.js 68.09% <80%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce809ef...fc71688. Read the comment docs.

@j-a-m-l j-a-m-l merged commit 36b3bda into next May 9, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/v2-4-peers branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.