Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync the `vendorField` maximum length from the network #1233

Merged
merged 7 commits into from May 10, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented May 9, 2019

Proposed changes

Update the maximum length admitted on the vendor field when the network provides a new value.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #1233 into next will increase coverage by 0.03%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1233      +/-   ##
==========================================
+ Coverage   38.65%   38.68%   +0.03%     
==========================================
  Files         224      224              
  Lines        6018     6026       +8     
  Branches     1200     1207       +7     
==========================================
+ Hits         2326     2331       +5     
- Misses       3481     3483       +2     
- Partials      211      212       +1
Impacted Files Coverage Δ
src/renderer/models/network.js 0% <ø> (ø) ⬆️
...action/TransactionForm/TransactionFormTransfer.vue 7.62% <ø> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 28.66% <ø> (-0.2%) ⬇️
src/renderer/services/client.js 69.06% <77.77%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa2a00...558a228. Read the comment docs.

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented May 10, 2019

FYI @j-a-m-l I had to fix a scenario for my existing devnet. The vendorfield value didn't exist at all, so it was never getting updated. When doing the !== currentNetwork.vendorField.maxLength check, it was silently failing, no errors or anything like "cannot get maxLength of undefined". Very weird.

@alexbarnsley alexbarnsley merged commit b5012d1 into next May 10, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the vendor-field-from-network branch May 10, 2019

@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Thanks, @alexbarnsley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.