Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provides the network wif to sign transactions #1249

Merged
merged 2 commits into from May 16, 2019

Conversation

@luciorubeens
Copy link
Member

commented May 16, 2019

Proposed changes

  • Signing transactions with encrypted wallets are not working;
  • The crypto package requires a second parameter to compare if the wif provided is compatible with the current network.

Reference: https://github.com/ArkEcosystem/core/blob/master/packages/crypto/src/builder/transactions/transaction.ts#L110

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
fix: provides the network wif to sign transactions
- Signing transactions with encrypted wallets are not working;
- The crypto package requires a second parameter to compare if the wif provided is compatible with the current network.
@codecov-io

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #1249 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1249   +/-   ##
=======================================
  Coverage   38.67%   38.67%           
=======================================
  Files         224      224           
  Lines        6035     6035           
  Branches     1206     1211    +5     
=======================================
  Hits         2334     2334           
+ Misses       3490     3489    -1     
- Partials      211      212    +1
Impacted Files Coverage Δ
...ransaction/TransactionForm/TransactionFormVote.vue 11.23% <ø> (ø) ⬆️
...TransactionForm/TransactionFormSecondSignature.vue 14.47% <ø> (ø) ⬆️
...action/TransactionForm/TransactionFormTransfer.vue 7.62% <ø> (ø) ⬆️
src/renderer/services/client.js 69.06% <0%> (ø) ⬆️
...actionForm/TransactionFormDelegateRegistration.vue 13.23% <0%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 28.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214b364...ad7cff1. Read the comment docs.

@j-a-m-l j-a-m-l merged commit 4849824 into next May 16, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/encrypted-password branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.