Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix(plugins): render components in production #1250

Merged
merged 3 commits into from May 17, 2019
Merged

Conversation

luciorubeens
Copy link
Contributor

Proposed changes

  • Change the rootPath;
  • When rendering the component, the component data no longer belongs to the context scope.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels May 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #1250 into next will increase coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1250      +/-   ##
==========================================
+ Coverage   38.67%   38.67%   +<.01%     
==========================================
  Files         224      224              
  Lines        6035     6037       +2     
  Branches     1206     1208       +2     
==========================================
+ Hits         2334     2335       +1     
  Misses       3490     3490              
- Partials      211      212       +1
Impacted Files Coverage Δ
src/renderer/services/plugin-manager.js 2.95% <28.57%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4849824...7a4412e. Read the comment docs.

@j-a-m-l j-a-m-l merged commit 897d07d into next May 17, 2019
@ghost ghost deleted the fix/template-compiler branch May 17, 2019 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants