Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): warn about using the plugin system #1257

Merged
merged 7 commits into from May 21, 2019

Conversation

Projects
None yet
4 participants
@j-a-m-l
Copy link
Contributor

commented May 20, 2019

Proposed changes

When the user tries to navigate to the plugins section, a modal would surge with a warning. If the user decides to enable them, that modal doesn't appear again.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented May 21, 2019

Codecov Report

Merging #1257 into next will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1257      +/-   ##
==========================================
- Coverage   38.65%   38.55%   -0.11%     
==========================================
  Files         224      225       +1     
  Lines        6046     6062      +16     
  Branches     1210     1213       +3     
==========================================
  Hits         2337     2337              
- Misses       3496     3511      +15     
- Partials      213      214       +1
Impacted Files Coverage Δ
...rc/renderer/components/Modal/ModalConfirmation.vue 57.14% <ø> (ø) ⬆️
...enderer/components/App/AppSidemenu/AppSidemenu.vue 0% <0%> (ø) ⬆️
src/renderer/models/profile.js 0% <0%> (ø) ⬆️
.../App/AppSidemenu/AppSidemenuPluginConfirmation.vue 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d903ab...d243be1. Read the comment docs.

@luciorubeens
Copy link
Member

left a comment

Seems to work only with new profiles. I created a profile in the next branch then I changed to this and the modal was not displayed.

Maybe it's something to add to the migration?

j-a-m-l added some commits May 21, 2019

Update src/renderer/models/profile.js
Co-Authored-By: Lúcio Rubens <4539235+luciorubeens@users.noreply.github.com>

@luciorubeens luciorubeens merged commit ad08943 into next May 21, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the warn-before-plugins branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.