Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: vendorField transaction assignment #1258
There is functionality in the crypto library that checks that the vendor field length is within the current milestone's value. This is with 2.3.22 of the crypto library. The desktop wallet currently uses 2.2.2, which hardcodes a 64 character limit, but neither work because of the lack of config.
Because the forms already do the validation of the length, we now simply set the vendor field value when building the transaction object.
Types of changes
requested review from
May 20, 2019
@@ Coverage Diff @@ ## next #1258 +/- ## ========================================== + Coverage 38.67% 38.68% +0.01% ========================================== Files 224 224 Lines 6038 6039 +1 Branches 1208 1208 ========================================== + Hits 2335 2336 +1 Misses 3491 3491 Partials 212 212