Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vendorField transaction assignment #1258

Merged
merged 2 commits into from May 21, 2019

Conversation

@alexbarnsley
Copy link
Member

commented May 20, 2019

Proposed changes

There is functionality in the crypto library that checks that the vendor field length is within the current milestone's value. This is with 2.3.22 of the crypto library. The desktop wallet currently uses 2.2.2, which hardcodes a 64 character limit, but neither work because of the lack of config.

Because the forms already do the validation of the length, we now simply set the vendor field value when building the transaction object.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #1258 into next will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1258      +/-   ##
==========================================
+ Coverage   38.67%   38.68%   +0.01%     
==========================================
  Files         224      224              
  Lines        6038     6039       +1     
  Branches     1208     1208              
==========================================
+ Hits         2335     2336       +1     
  Misses       3491     3491              
  Partials      212      212
Impacted Files Coverage Δ
src/renderer/services/client.js 69.15% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f63a8...22c4f8c. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 81d525f into next May 21, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/vendorfield-tx-assignment branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.