fix(plugins): tidy permission method names & check exists #1260
There are some plugin permissions that do not load methods. This wasn't being catered for, so it tried to load methods for all permissions which errored if the method did not exist.
Also updated permission load method names.
Types of changes
requested review from
May 22, 2019
@@ Coverage Diff @@ ## develop #1260 +/- ## =========================================== - Coverage 40.22% 40.21% -0.02% =========================================== Files 228 228 Lines 6284 6286 +2 Branches 1231 1233 +2 =========================================== Hits 2528 2528 Misses 3538 3538 - Partials 218 220 +2
May 29, 2019
1 check passed
ci/circleci: test-node-11 Your tests passed on CircleCI!Details
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.