Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "next" branch into "develop" #1262

wants to merge 58 commits into from


Copy link

commented May 22, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
alexbarnsley and others added 30 commits Mar 28, 2019
feat: initial plugin system implementation (#1159)
* feat: plugin manager & store

* feat: add plugin ui

* chore: keep plugins folder

* refactor: plugins improved & load for all profiles

* feat: plugin page output id and version

* fix: allow for empty permissions

* feat: allow avatars from plugins

* fix: use plugin manager vue plugin

* fix: avatar sidebar position no plugin avatar

* feat: multi-column plugin menu items

* refactor: prevent unauthorised component access

- store avatar components in Plugin Manager, don't pass to vuex store
- await all plugin methods in case they're async
- allow vue inside of plugins since component render is now done inside a vm2 sandbox
- loads all plugins in one go, and is then referenced from each area by name

* fix: only run plugin register method if exists

* feat: add plugins route

* fix: use wallet vue package instead of plugin

* fix: remove document from plugin sandbox

* fix: plugin component template loops

* chore: add plugin security TODO

* chore: rename to plugin manager in settings

* fix: load plugin manager first

* fix: don't await plugins

* chore: add fs-extra to depcheck
fix: add network modal validation (#1173)
* fix: network validation being overwritten

* feat: pull active delegates from api

* fix: make sure active delegates value exists

* refactor: improve server regex

* test: network modal for adding network

* chore: replace todo with comment

* fix: use one loop with prefilled values as backup

* refactor: allow string or number for input text

* refactor: allow fetching fees for specific network

* fix: fetch network fees when adding/editing

* fix: fetch fees & wait before add/update
fix: do not filter peers based on higher height
- If a bad peer has a height 50 blocks above the rest it is not returning any peer;
- This happens in devnet, which makes it impossible to select another peer.
fix: profile model validation to use letter avatar (#1205)
- The avatar property in the profile model was merging the specifications of two types;
- Used the JSON Schema directive `anyOf` to set the specs separately.
fix: do not break letter avatars when switching languages (#1214)
* refactor: `SelectionAvatar`

* fix: do not break letter avatars when switching languages
fix: value of letter avatar on profile (#1213)
* fix: remove nonexistent property check

* docs: comment avatar of profile model

* refactor: check for invalid avatars when editing profiles

* fix: value of letter avatar on profile creation

* fix: migration to fix inconsistencies among avatars
feat: new icon to disconnect from custom peer (#1208)
* feat: include the new icon for disconnecting from custom peer

* feat: adjust the style of the refresh/disconnect peer button

* fix: rounded corners of peer input

* fix: align refresh/disconnect button
j-a-m-l and others added 21 commits May 7, 2019
fix: fee statistics for 2.4 (#1230)
* chore: update @arkecosystem/client

* feat: try new fees endpoint first
feat: sync vendorField maximum length from the network (#1233)
* misc: update mainnet and devnet `vendorField` configuration

* refactor: stricter schema for network model on `vendorField`

* feat: store the maximum length of the vendor field of custom networks

* feat: sync the `vendorField` maximum length from the network

* test: adapt

* fix: setting vendor field if not already
fix(plugins): do not allow a plugin theme during profile creation (#1235

* fix(plugins): do not allow choosing a plugin theme during profile creation

* fix(plugins): change to default theme when coming from a profile using a plugin theme
feat(plugins): warn about using the plugin system (#1257)
* refactor(plugins): more explicit name

* feat(plugins): warn about using the plugin system

* fix(plugins): ensure that the warning about plugins is displayed in more scenarios

* Update src/renderer/models/profile.js

This comment has been minimized.

Copy link

commented May 22, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
8 participants
You can’t perform that action at this time.