Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a button to navigate back to the previous wallet page #1273

Merged
merged 8 commits into from Jun 28, 2019

Conversation

Projects
None yet
4 participants
@j-a-m-l
Copy link
Contributor

commented May 31, 2019

Resolves #1236

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Waiting to:

  • decision about the scope of the button (globally or only on wallets pages)
  • design
@codecov-io

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #1273 into develop will decrease coverage by 0.05%.
The diff coverage is 6.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1273      +/-   ##
===========================================
- Coverage    39.94%   39.88%   -0.06%     
===========================================
  Files          228      229       +1     
  Lines         6337     6345       +8     
  Branches      1252     1246       -6     
===========================================
  Hits          2531     2531              
- Misses        3584     3593       +9     
+ Partials       222      221       -1
Impacted Files Coverage Δ
src/renderer/components/Wallet/WalletAddress.vue 51.72% <ø> (ø) ⬆️
src/renderer/components/App/AppBackButton.vue 0% <0%> (ø)
src/renderer/App.vue 0% <0%> (ø) ⬆️
...ponents/Wallet/WalletHeading/WalletHeadingInfo.vue 62.16% <100%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 29.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961f144...996cd4a. Read the comment docs.

@j-a-m-l j-a-m-l changed the title feat: add a button to the main sidebar to navigate back to the previous page feat: add a button to navigate back to the previous wallet page Jun 3, 2019

@j-a-m-l j-a-m-l force-pushed the navigate-back branch from a407a97 to 4d7d735 Jun 24, 2019

j-a-m-l added some commits Jun 25, 2019

@j-a-m-l j-a-m-l marked this pull request as ready for review Jun 25, 2019

Show resolved Hide resolved src/renderer/App.vue Outdated
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@luciorubeens luciorubeens merged commit 5b53de6 into develop Jun 28, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the navigate-back branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.