Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a switch button on the dashboard to show or hide the market chart #1274

Merged
merged 8 commits into from Jul 3, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented May 31, 2019

Resolves #1238

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@j-a-m-l j-a-m-l changed the title feat: add a switch button to the dashboard to display or hide the mar… feat: add a switch button to the dashboard to display or hide the market chart May 31, 2019

@j-a-m-l j-a-m-l changed the title feat: add a switch button to the dashboard to display or hide the market chart feat: add a switch button on the dashboard to show or hide the market chart May 31, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #1274 into develop will decrease coverage by 0.04%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1274      +/-   ##
===========================================
- Coverage    39.88%   39.84%   -0.05%     
===========================================
  Files          229      229              
  Lines         6345     6354       +9     
  Branches      1253     1249       -4     
===========================================
+ Hits          2531     2532       +1     
- Misses        3592     3601       +9     
+ Partials       222      221       -1
Impacted Files Coverage Δ
...rc/renderer/components/MarketChart/MarketChart.vue 20.79% <0%> (-0.43%) ⬇️
src/renderer/pages/Dashboard.vue 17.24% <33.33%> (-3.6%) ⬇️
...derer/components/MarketChart/MarketChartHeader.vue 57.14% <66.66%> (-2.86%) ⬇️
src/renderer/components/Network/NetworkModal.vue 29.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b53de6...1b8c7b3. Read the comment docs.

j-a-m-l added some commits Jun 17, 2019

src/renderer/pages/Dashboard.vue Outdated Show resolved Hide resolved
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

j-a-m-l and others added some commits Jun 28, 2019

@luciorubeens luciorubeens merged commit 990789f into develop Jul 3, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the show-chart-button branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.